Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have V3EmitC::emitcSyms honor --output-split-cfuncs #1499

Closed
veripoolbot opened this issue Sep 3, 2019 · 5 comments
Closed

Have V3EmitC::emitcSyms honor --output-split-cfuncs #1499

veripoolbot opened this issue Sep 3, 2019 · 5 comments

Comments

@veripoolbot
Copy link
Contributor

@veripoolbot veripoolbot commented Sep 3, 2019


Author Name: Todd Strader (@toddstrader)
Original Redmine Issue: 1499 from https://www.veripool.org

Original Assignee: Todd Strader (@toddstrader)


I'm planning to modify V3EmitC::emitcSyms to respect --output-split-cfuncs in order to break up the symbol object constructor. This looks reasonably straightforward with the existing class. However, I know the long term desire is to refactor this into a proper AST visitor class.

Would it be acceptable to add this feature to the existing class without refactoring it?

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Sep 3, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-09-03T20:33:25Z


Proposed change:
https://github.com/toddstrader/verilator-dev/tree/sym-split

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Sep 3, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-09-03T23:37:57Z


It just dawned on me that I didn't modify t_flag_csplit.pl to verify that it is now producing Syms__#.cpp files (which it is). I'll add that when I can get back to this.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Sep 4, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-09-04T01:33:33Z


Good stuff, thanks.

Once you update tests feel free to squash and push.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Sep 4, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-09-04T10:24:44Z


Done. This has been pushed to git now.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Oct 6, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-10-06T14:07:07Z


In 4.020. Thanks for reporting this; if there are additional related problems, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.