Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPI: Get vpiType string #1510

Closed
veripoolbot opened this issue Sep 18, 2019 · 5 comments
Closed

VPI: Get vpiType string #1510

veripoolbot opened this issue Sep 18, 2019 · 5 comments

Comments

@veripoolbot
Copy link

@veripoolbot veripoolbot commented Sep 18, 2019


Author Name: Stefan Wallentowitz (@wallento)
Original Redmine Issue: 1510 from https://www.veripool.org

Original Assignee: Stefan Wallentowitz (@wallento)


vpi_get_str: Get vpiType string

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Sep 18, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-09-18T11:18:48Z


Thanks for the patch, makes sense, could you also please add a test to t_vpi_get.cpp or one of the other tests? If not I'll get to it.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Sep 18, 2019


Original Redmine Comment
Author Name: Stefan Wallentowitz (@wallento)
Original Date: 2019-09-18T11:19:47Z


Yes, I am at it right now. Sorry, slipped me :)

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Sep 18, 2019


Original Redmine Comment
Author Name: Stefan Wallentowitz (@wallento)
Original Date: 2019-09-18T11:45:46Z


Patch updated with test. Actually I found vpi_var the better test as it tests vpi_get_str too.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Sep 18, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-09-18T16:24:55Z


Great. Pushed to git for eventual release 4.020.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Oct 6, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-10-06T14:07:28Z


In 4.020. Thanks for reporting this; if there are additional related problems, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.