Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPI: Let port vars return variable type, not vpiPort #1528

Closed
veripoolbot opened this issue Sep 26, 2019 · 3 comments
Closed

VPI: Let port vars return variable type, not vpiPort #1528

veripoolbot opened this issue Sep 26, 2019 · 3 comments

Comments

@veripoolbot
Copy link

@veripoolbot veripoolbot commented Sep 26, 2019


Author Name: Stefan Wallentowitz (@wallento)
Original Redmine Issue: 1528 from https://www.veripool.org

Original Assignee: Stefan Wallentowitz (@wallento)


VerilatedVpioVar does not provide any of the other properties of the vpiPort, but those of the referenced "vpiLowConn" object. Also the method is not actually available to access this object. I think it was intended that this is actually this object. Thus it should also return the proper type for those variables.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Sep 27, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-09-27T04:02:52Z


Not sure I follow what this helps, but don't see what it breaks either and tests don't cover it, so will assume it helps ;)

Pushed to git towards eventual 4.020 release.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Sep 29, 2019


Original Redmine Comment
Author Name: Stefan Wallentowitz (@wallento)
Original Date: 2019-09-29T15:25:14Z


Just for completeness. When it return vpiPort, the proper sequence would be something like:

vpi_handle port = vpi_handle_by_name("top.mod.port", NULL);
vpi_handle obj = vpi_handle(vpiLowConn, port);
vpi_get_value(obj, v);

This is not supported, plus all the properties of the port are not available as it is a simple variable. Hence we directly return it as variable and access it as:

vpi_handle obj = vpi_handle_by_name("top.mod.port", NULL);
vpi_get_value(obj, v);

As long as we don't provide properties and operations on vpiPort it is hence not very useful.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Oct 6, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-10-06T14:08:10Z


In 4.020. Thanks for reporting this; if there are additional related problems, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.