Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_regress/t_prot_lib is unstable #1580

Closed
veripoolbot opened this issue Nov 2, 2019 · 4 comments
Closed

test_regress/t_prot_lib is unstable #1580

veripoolbot opened this issue Nov 2, 2019 · 4 comments

Comments

@veripoolbot
Copy link
Contributor

@veripoolbot veripoolbot commented Nov 2, 2019


Author Name: Wilson Snyder (@wsnyder)
Original Redmine Issue: 1580 from https://www.veripool.org

Original Assignee: Todd Strader (@toddstrader)


Debugging a test makefile cleanup, I realized why t_prot_lib and t_noprot_lib seem to fail occasionally for me, but then passes on rerun.

Both run t_prot_lib_secret.pl, so there's up to three running (t_prot_lib's, noprot's and secret form the original driver). If they run simultaneously they break.

Suggest we leave t_prot_lib_secret.pl as is, but have t_prot_lib/t_noprot_lib instead of calling the secret.pl test, just run the verilator command standalone putting output in e.g. {obj_dir}/secret/.... (or otherwise). Then each test will be self-contained.

Let me know if you prefer if I do this.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Nov 2, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-11-02T16:46:23Z


Todd wrote it originally...

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Nov 5, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-11-05T12:43:57Z


This should resolve the issue and make the tests self-contained:
https://github.com/toddstrader/verilator-dev/tree/prot-lib-test-fix

I'm not sure why you would have seen this with t_noprot_lib as it does not call t_prot_lib_secret.pl (since it's building a monolithic version of the same thing). I looked around in Travis for an example of any of these reruns but couldn't find any. However, that may be a result of Travis' limited core count.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Nov 5, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-11-05T13:43:22Z


Thanks, feel free to push and close, no need for a Changes update.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Nov 5, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-11-05T13:51:40Z


Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.