Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis Mail not going to authors? #1618

Closed
veripoolbot opened this issue Dec 2, 2019 · 5 comments
Closed

Travis Mail not going to authors? #1618

veripoolbot opened this issue Dec 2, 2019 · 5 comments

Comments

@veripoolbot
Copy link
Contributor

@veripoolbot veripoolbot commented Dec 2, 2019


Author Name: Wilson Snyder (@wsnyder)
Original Redmine Issue: 1618 from https://www.veripool.org

Original Assignee: Todd Strader (@toddstrader)


Re issue 1617:

BTW, something, maybe your email-yourself?, seems to have broken the author of the commit getting email on the breakage, so I hadn't noticed. Perhaps ideal behavior would be both of us get all fails, plus the author?

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Dec 2, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-12-02T13:16:39Z


You're right. The default Travis behavior is to email the author and committer. But if you specify an email recipients list, that replaces the default recipients (which was not the intended effect). It also doesn't appear that you can extend the recipient list instead of replacing it. I agree that we should be able to get emails going to the author + a list of interested individuals.

For now, I'll band-aid it by adding you to the list. I'll check with the Travis folks to see if there is a more elegant solution, but I may have to go to something more involved like webhooks. Hopefully not.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Dec 2, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-12-02T14:07:29Z


If travis has nothing to fix this, perhaps instead of overriding email, have a end-of-run script that simply does a sendmail to us passing the relevant build URL?

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Dec 7, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-12-07T14:08:26Z


Todd, Email working, can this be closed, or more to do?

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Dec 7, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-12-07T14:30:49Z


Yeah, it mostly works now. Currently, you and I will get emails on any failures or transitions from failing to passing. But authors and committers are not getting emails at present. Ideally we'd be able to add our list of recipients to the default of author and committer, but I'm told Travis can't do that.

I can try your suggestion of manually emailing on failure so that authors and committers still get emails. The only problem with that is that people (mainly you) will get twice the email if they are both the committer and on the recipient list. Also, it (probably) won't be stateful so we wouldn't get the failing -> passing emails.

At this point I'm inclined to say this is good enough because if someone else breaks the build we can/will let them know. Also, if they had CI running on their fork, they'd have already gotten an email. Thoughts?

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Dec 7, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-12-07T16:35:24Z


Seems reasonable for now, we can get fancier later if need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.