Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Gtkwave update breaks verilator_ext_tests #1633
Original Assignee: Wilson Snyder (@wsnyder)
t_gtkwave_diff is failing because gtkwave has updated fstapi.[ch]:
The test is mad about this gtkwave commit:
This diff is mostly new functions, however there are other small changes. I can copy this into Verilator and check the regression tests if desired to make verilator_ext_tests happy. However, if gtkwave is really being hosted on GitHub now, should we just make gtkwave a submodule of Verilator? That way we can stop copying these files around and lose the consistency check.
Original Redmine Comment
I had added the ext test to catch this sort of delta.
Gtkwave is now in github, that repo is the new master.
Until we have a more serious need, I'd like to avoid submodule requirements, as it adds friction which may reduce people's ability to install it.
Anyhow, the API change was on a request I had made for a performance enhancement, so updated everything to latest and updated our calling code for the new API.
Passes locally, presuming will satisfy Travis, if not reopen.