Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support $countbits (starter task) #1639

Closed
veripoolbot opened this issue Dec 15, 2019 · 4 comments
Closed

Support $countbits (starter task) #1639

veripoolbot opened this issue Dec 15, 2019 · 4 comments

Comments

@veripoolbot
Copy link
Contributor

@veripoolbot veripoolbot commented Dec 15, 2019


Author Name: Wilson Snyder (@wsnyder)
Original Redmine Issue: 1639 from https://www.veripool.org


Good starter task is to implement and test $countbits, which is a generation of $countones etc.

The existing $countones functions inside V3Number could be removed to use the new generic countbits. The runtime functions in verilated.h should remain specialized, as that will help performance.

@ynivin
Copy link
Contributor

@ynivin ynivin commented Jan 11, 2020

I'm currently working on implementation for this here: https://github.com/ynivin/verilator/tree/issue-1639
I would create PR once I have something working.

@wsnyder
Copy link
Member

@wsnyder wsnyder commented Mar 1, 2020

How is this going? Need a review or other assistance?

@ynivin
Copy link
Contributor

@ynivin ynivin commented Mar 1, 2020

How is this going? Need a review or other assistance?

I had some very busy months and didn't have the chance to complete it yet.
I plan to work on it in the next few weeks.

@wsnyder
Copy link
Member

@wsnyder wsnyder commented May 10, 2020

Merged with #2287. Thanks for your work on this.

@wsnyder wsnyder closed this May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants