Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strcasecmp is not found on Windows #1651

Closed
veripoolbot opened this issue Dec 20, 2019 · 2 comments
Closed

strcasecmp is not found on Windows #1651

veripoolbot opened this issue Dec 20, 2019 · 2 comments

Comments

@veripoolbot
Copy link

@veripoolbot veripoolbot commented Dec 20, 2019


Author Name: Kuba Ober
Original Redmine Issue: 1651 from https://www.veripool.org

Original Assignee: Kuba Ober


strcasecmp is used in two places, but is not supported by the Windows CRT. Yet VL_STRCASECMP exists and fixes this.

Fixed by KubaO@f1c43df

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Dec 20, 2019


Original Redmine Comment
Author Name: Kuba Ober
Original Date: 2019-12-20T08:57:23Z


Sorry, added a branch for that: https://github.com/KubaO/verilator/tree/feature/fix-strcasecmp

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Dec 20, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-12-20T12:02:30Z


Much appreciate getting bugs with good patches to fix them.

Fixed in git as part of 4.025 devel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.