Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long if-else chain hitting MSVC's limit. #1654

Closed
veripoolbot opened this issue Dec 21, 2019 · 2 comments
Closed

Fix long if-else chain hitting MSVC's limit. #1654

veripoolbot opened this issue Dec 21, 2019 · 2 comments

Comments

@veripoolbot
Copy link

@veripoolbot veripoolbot commented Dec 21, 2019


Author Name: Kuba Ober
Original Redmine Issue: 1654 from https://www.veripool.org

Original Assignee: Kuba Ober


There's an if-else chain in V3Option.cpp that goes past MSVC's limit of 128 blocks. Splitting it into to parts is a low-cost workaround.

The fix is in https://github.com/KubaO/verilator/tree/feature/fix-option-chain-msvc

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Dec 21, 2019


Original Redmine Comment
Author Name: Kuba Ober
Original Date: 2019-12-21T00:35:54Z


This is also #7

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Dec 21, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-12-21T01:11:19Z


Thanks for the patch, makes sense. Pushed to git towards 4.026.

BTW if you have a pull request that you think completely fixes something, feel free to skip making a bug here (fine if you still want to though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.