Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parentheses around a single module parameter optional #179

Closed
veripoolbot opened this issue Nov 10, 2009 · 3 comments
Closed

Make parentheses around a single module parameter optional #179

veripoolbot opened this issue Nov 10, 2009 · 3 comments

Comments

@veripoolbot
Copy link
Contributor

@veripoolbot veripoolbot commented Nov 10, 2009


Author Name: Byron Bradley (@bbradley)
Original Redmine Issue: 179 from https://www.veripool.org
Original Date: 2009-11-10
Original Assignee: Byron Bradley (@bbradley)


The parentheses around parameters when a module is instantiated is optional in VCS if there is only one parameter, e.g.:

      m1 #PAR m1();                                                                                                                
      m3 #PAR m3();                                                                                                                
      mnooverride #10 mno();

works in VCS but Verilator currently requires #(PAR) and #(10).

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Nov 10, 2009


Original Redmine Comment
Author Name: Byron Bradley (@bbradley)
Original Date: 2009-11-10T20:55:29Z


Attached diff makes these parentheses optional and includes a testcase. I've also rolled in a typo fix to Changes and made it ignore vim backup files.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Nov 10, 2009


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2009-11-10T21:40:24Z


Thanks! I'll forgive your use of VI this time, since I botched your name. :)

Pushed to git for 3.730++.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Feb 7, 2010


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2010-02-07T12:41:22Z


In 3.800.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.