Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit Vars aren't always created under Pins #196

Closed
veripoolbot opened this issue Dec 8, 2009 · 3 comments
Closed

Implicit Vars aren't always created under Pins #196

veripoolbot opened this issue Dec 8, 2009 · 3 comments

Comments

@veripoolbot
Copy link
Contributor

@veripoolbot veripoolbot commented Dec 8, 2009


Author Name: Byron Bradley (@bbradley)
Original Redmine Issue: 196 from https://www.veripool.org
Original Date: 2009-12-08
Original Assignee: Wilson Snyder (@wsnyder)


Test case attached. Implicit Vars are created in V3Link for VarRefs under a Pin, however, if the connection isn't simple, e.g.:

read r (.clk(clk), .data( ( ( oe == 1'd1 ) && write ) ) );

The function pinImplicitExprRecurse() won't create the Var for write. There's already a special case to handle this in an AstConcat, can we just change this to an AstNodeBiop?

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Dec 8, 2009


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2009-12-08T23:33:58Z


Not only Biops, because ".z(~implicit)" which is a UniOp should work too.
There's some things that probably shouldn't make implicits,
but the spec says all so I'll just look for a VarRef under
anything.

Fixed in git for 3.721+

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Dec 8, 2009


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2009-12-08T23:34:32Z


BTW, thanks lots for a test case I can just add!

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Feb 7, 2010


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2010-02-07T12:41:48Z


In 3.800.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.