Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signals in a concatenation on the LHS aren't created implicitly #208

Closed
veripoolbot opened this issue Jan 19, 2010 · 2 comments
Closed

Signals in a concatenation on the LHS aren't created implicitly #208

veripoolbot opened this issue Jan 19, 2010 · 2 comments

Comments

@veripoolbot
Copy link
Contributor

@veripoolbot veripoolbot commented Jan 19, 2010


Author Name: Byron Bradley (@bbradley)
Original Redmine Issue: 208 from https://www.veripool.org
Original Date: 2010-01-19
Original Assignee: Byron Bradley (@bbradley)


Signals in a concatenation on the LHS aren't created implicitly, e.g.:

     logic [1:0] dummy_ip;
     assign {dummy1, dummy2} = dummy_ip;

Fails to create dummy1 and dummy2. Test case and proposed patch attached, I originally just checked for VarRefs in op[1234]p but didn't see any harm in calling pinImplicitExprRecurse() instead.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jan 19, 2010


Original Redmine Comment
Author Name: Byron Bradley (@bbradley)
Original Date: 2010-01-19T22:11:10Z


Attaching an updated patch, the last one introduced an unused variable.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jan 20, 2010


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2010-01-20T00:35:20Z


Applied to git, thanks for the patch.

This is on top of unreleased #�, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.