Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protect_lib and gated clock #2169

Open
fuyong10 opened this issue Feb 14, 2020 · 3 comments
Open

protect_lib and gated clock #2169

fuyong10 opened this issue Feb 14, 2020 · 3 comments
Assignees
Labels
new

Comments

@fuyong10
Copy link

@fuyong10 fuyong10 commented Feb 14, 2020

For testing gated clock purpose, I modified secret_impl.v under make_protect_lib example:

 always @(posedge clk) begin

changed to:
wire GC = clk & a[0];
always @(posedge GC) begin

Compile error. Seems like obj_dir_secret/verilated_secret.sv is not generated correctly:

// Evaluate clock edges
always @( ) begin   <==== sensitive list is empty.
@fuyong10 fuyong10 added the new label Feb 14, 2020
@toddstrader

This comment has been minimized.

Copy link
Member

@toddstrader toddstrader commented Feb 14, 2020

Yeah, that definitely sounds like a --protect-lib code generation bug. Do you want to make a PR for a new test in test_regression and/or a fix for this? If not, I can take a look.

@fuyong10

This comment has been minimized.

Copy link
Author

@fuyong10 fuyong10 commented Feb 14, 2020

I am quite new to Verilator so really not capable of fixing yet. Please go ahead and take a look.

Ps, what does "PR" here mean?

@Millennium-Software-Design

This comment has been minimized.

Copy link

@Millennium-Software-Design Millennium-Software-Design commented Feb 15, 2020

PR: Pull Request. See https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests

(in the good ol' days we just said, "patch")

@toddstrader toddstrader self-assigned this Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.