Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for import modport #696

Closed
veripoolbot opened this issue Nov 7, 2013 · 6 comments
Closed

Add support for import modport #696

veripoolbot opened this issue Nov 7, 2013 · 6 comments

Comments

@veripoolbot
Copy link

@veripoolbot veripoolbot commented Nov 7, 2013


Author Name: Jeremy Bennett (@jeremybennett)
Original Redmine Issue: 696 from https://www.veripool.org
Original Date: 2013-11-07
Original Assignee: Wilson Snyder (@wsnyder)


This is an enhancement request to add @import@ and @export@ to interface modports.

Please pull simple testcases from branch modport-import-export of https://github.com/jeremybennett/verilator

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Nov 10, 2013


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2013-11-10T18:38:20Z


modport_import makes sense.

modport_export makes other simulators upset; I think myfunc needs to be predeclared as an extern.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Nov 15, 2013


Original Redmine Comment
Author Name: Jeremy Bennett (@jeremybennett)
Original Date: 2013-11-15T09:09:50Z


Hi Wilson,

My bad - I didn't test the export example properly. I've pushed an improved version, which passes with VCS. It does require the extern declaration, which by my reading of the standard should not be necessary.

Jeremy

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Dec 21, 2013


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2013-12-21T11:53:20Z


Modport import is fixed in git towards 3.855.

Could you confirm the usefulness of export in synthesized code? Export messes with how linking currently works, so will be a bit of a mess.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Dec 31, 2013


Original Redmine Comment
Author Name: Jeremy Bennett (@jeremybennett)
Original Date: 2013-12-31T19:18:12Z


Hi Wilson,

Sorry for the slow follow-up over the holiday period. Hope you had a good Christmas and best wishes for 2014.

I agree with you on this. I think import is the one that really matters. I found export didn't quite do what I expected with event driven simulation, so just modport_import should be sufficient. That's all the big SystemVerilog test case uses.

Jeremy

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Jan 7, 2014


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2014-01-07T01:24:06Z


Import only then. Resolved with earlier commit.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Jan 18, 2014


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2014-01-18T18:29:48Z


In 3.855.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.