Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug in t_vpi_get test #794

Closed
veripoolbot opened this issue Jun 26, 2014 · 1 comment
Closed

Small bug in t_vpi_get test #794

veripoolbot opened this issue Jun 26, 2014 · 1 comment

Comments

@veripoolbot
Copy link

@veripoolbot veripoolbot commented Jun 26, 2014


Author Name: Jeremy Bennett (@jeremybennett)
Original Redmine Issue: 794 from https://www.veripool.org
Original Date: 2014-06-26
Original Assignee: Jeremy Bennett (@jeremybennett)


Recent GCC's complain about the C code in @test_regress/t/t_vpi_get.cpp@:

test_regress/t/t_vpi_get.cpp:168:1: error: narrowing conversion of ‘(TestSimulator::is_verilator() ? 48 : 29)’ from ‘int’ to ‘unsigned int’ inside { } is ill-formed in C++11 [-Werror=narrowing]

This is fixed by changing the @type@ field of the @params@ struct to type @int@.

Please pull a patch from branch vpi-test-bug of git@github.com:jeremybennett/verilator.git

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Jun 27, 2014


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2014-06-27T01:46:18Z


Thanks for the patch! Fixed in git towards 3.863.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.