Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for only dump-tree in selective processing step #894

Closed
veripoolbot opened this issue Mar 9, 2015 · 6 comments
Closed

Support for only dump-tree in selective processing step #894

veripoolbot opened this issue Mar 9, 2015 · 6 comments

Comments

@veripoolbot
Copy link

@veripoolbot veripoolbot commented Mar 9, 2015


Author Name: Jie Xu (@jiexu)
Original Redmine Issue: 894 from https://www.veripool.org
Original Date: 2015-03-09


currently we have --dump-treei level which can specify the level of tree dump. It is still bit difficult to use and the cost of dumping all trees are quite high.

It would be nice to have something --dump-tree-V3Order which basically means only dump the tree in V3Order.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Mar 9, 2015


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2015-03-09T19:49:47Z


I usually use -debugi-V3Order 9. But perhaps you'd like to contribute a patch to add -dump-treei-?

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Mar 9, 2015


Original Redmine Comment
Author Name: Jie Xu (@jiexu)
Original Date: 2015-03-09T20:08:36Z


Yes. I use that as well. But my point is that most of time I am only interested some steps (for example just V3Gate and V3Order, then I can using just -dump-tree-V3Gate --dump-tree-V3Order) instead of dumping all the tree files.

I can definitely make a patch for that. But that means I will move all the tree dumping to separate files instead of in Veriator.cpp. Do you think that is OK?

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Mar 10, 2015


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2015-03-10T01:10:17Z


that means I will move all the tree dumping to separate files instead of in Veriator.cpp. Do you think that is OK?

Ok.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Mar 10, 2015


Original Redmine Comment
Author Name: Jie Xu (@jiexu)
Original Date: 2015-03-10T14:41:26Z


Please have a check: https://github.com/jiexu/verilator.git issue894. Have removed the automatically setting dump-tree in "--debug".

Passes all regression tests except some tracing issues.

======================================================================
TESTS Passed 642  Unsup 18  Skipped 22  Failed 4  Time 3:49
         #vlt/t_order_multidriven: %Error: Exec of cd obj_dir/t_order_multidriven &&  failed
                 make && test_regress/t/t_order_multidriven.pl --vlt
         #vlt/t_trace_cat: %Error: Exec of cd obj_dir/t_trace_cat &&  failed
                 make && test_regress/t/t_trace_cat.pl --vlt
         #vlt/t_trace_cat_renew: %Error: Exec of cd obj_dir/t_trace_cat_renew &&  failed
                 make && test_regress/t/t_trace_cat_renew.pl --vlt
         #vlt/t_trace_cat_reopen: %Error: Exec of cd obj_dir/t_trace_cat_reopen &&  failed
                 make && test_regress/t/t_trace_cat_reopen.pl --vlt
TESTS Passed 642  Unsup 18  Skipped 22  Failed 4  Time 3:49


@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Mar 12, 2015


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2015-03-12T23:50:11Z


Thanks for the patch pushed to git for 3.871.

I changed it so that --debug still implies --dump-treei 3 for backward compatibility. If you don't want that use e.g. "--debug --dump-treei 3 --dump-treei-FILE 9"

I don't see any trace failures, it might be system specific, if so please file a bug showing how it fails.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Apr 5, 2015


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2015-04-05T15:00:32Z


In 3.872.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.