Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuzzing infrastructure. #4

Closed
wants to merge 4 commits into from
Closed

Add fuzzing infrastructure. #4

wants to merge 4 commits into from

Conversation

@1425
Copy link
Contributor

1425 commented Oct 12, 2019

nodist/fuzzer/actual_fail Outdated Show resolved Hide resolved
@1425

This comment has been minimized.

Copy link
Contributor Author

1425 commented Oct 12, 2019

I've migrated the Python 2 to Python 3. As far as using Python at all, I asked that here:

https://www.veripool.org/issues/1534-Verilator-Fuzzer-script#note-4

Although I didn't get a definitive answer.

Signed-off-by: Eric Rippey <rippey.e@gmail.com>
@1425

This comment has been minimized.

Copy link
Contributor Author

1425 commented Oct 15, 2019

Travis CI is now complaining that my github username is not in the contributor list. Obviously a string of numbers is not my real name, and my name does appear in the contributors list. Do you have any advice on how to proceed?

@wsnyder

This comment has been minimized.

Copy link
Member

wsnyder commented Oct 15, 2019

@toddstrader can you please investigate this t_dist_contrib issue? Thanks.

@toddstrader

This comment has been minimized.

Copy link
Member

toddstrader commented Oct 15, 2019

Can do. I'm just on my phone now, so I'll investigate more later but I think it's just that this test is looking for the commiter's name in CONTRIBUTORS. I think this also came up in the CMake PR. I believe someone just changed their name for this repo to their actual name to pass the test. Not sure if this was a local git config change or something done via GitHub.

@wsnyder

This comment has been minimized.

Copy link
Member

wsnyder commented Oct 16, 2019

Thanks, think the fundamentals are all here.

  1. Please add to internals.adoc a section on how to run it.
  2. Please add copyright headers at the top of every file e.g.
# DESCRIPTION: One line description of thingie......
#
# Copyright 2019-2019 by Wilson Snyder. This package is free software; you can
# redistribute it and/or modify it under the terms of either the GNU Lesser
# General Public License Version 3 or the Perl Artistic License Version 2.0.
######################################################################
  1. Please use // comments in the .cpp file
  2. Please put space after "#" before starting comment text.
  3. Please put space around "=" in python & cpp.

If you prefer I'll do 2-5 for you.

Then looks good to go.

@toddstrader

This comment has been minimized.

Copy link
Member

toddstrader commented Oct 16, 2019

@1425 I believe if you just change your name to how it appears in docs/CONTRIBUTORS you'll pass the test. You can change this in your .gitconfig or with git config. This won't affect your GitHub name, but will change how you show up in the git log which is what matters for the test.

To test this I went the opposite way and changed my name so it would fail:
https://travis-ci.com/toddstrader/verilator-dev/jobs/246222215

@wsnyder

This comment has been minimized.

Copy link
Member

wsnyder commented Oct 17, 2019

Pushed with minor space/comment changes, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.