Fix wildcard equality and inside operators for non-fourstate expressions #5673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RRozak
changed the title
wsnyder
reviewed
Dec 12, 2024
Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
RRozak
force-pushed
the
rrozak/fix-inside
branch
from
3fc3b8b to
80ecbb5
Compare
wsnyder
approved these changes
Dec 12, 2024
Member
wsnyder
left a comment
wsnyder
left a comment
There was a problem hiding this comment.
Thanks, feel free to squash merge once passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contrary to what the comment says, the Spec allows for non-constant rhs. This PR allows for
==?and!=?operators if the RHS is non-fourstate. It also makes possible to use these types ininsideoperator, because Verilator convertsinsideto==?.