Support nested classes (#4178) - #5778
Merged
Merged
Conversation
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
wsnyder
changed the title
wsnyder
changed the title
wsnyder
reviewed
Feb 14, 2025
wsnyder
left a comment
wsnyder
left a comment
Member
There was a problem hiding this comment.
Well done, I especially appreciate the good testing.
In what ways is this only "initial" vs "complete"? (I'm surprised there weren't more back end and optimizer changes needed.)
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Member
Author
I think, that it is quite complete. I've added tests for nested classes with parameters, extends, I added |
magancarz
pushed a commit
to antmicro/verilator
that referenced
this pull request
Mar 5, 2025
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4178.
This PR enable initial support for nested classes.