Repository navigation
Support simple disable within task - #6334
Conversation
Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
There was a problem hiding this comment.
Thanks. BTW for later/long term would be great to get these from sv_tests passing too!
== "task disable"
regress-sv_clkgen_bit_iv,1,disable,%Error: sv-tests/third_party/tools/icarus/ivtest/ivltests/clkgen_bit.v:12:4: disable isn't underneath a begin with name: 'checking'
regress-sv_clkgen_logic_iv,1,disable,%Error: sv-tests/third_party/tools/icarus/ivtest/ivltests/clkgen_logic.v:13:4: disable isn't underneath a begin with name: 'checking'
regress-sv_clkgen_net_iv,1,disable,%Error: sv-tests/third_party/tools/icarus/ivtest/ivltests/clkgen_net.v:16:4: disable isn't underneath a begin with name: 'checking'
regress-sv_clkgen_reg_iv,1,disable,%Error: sv-tests/third_party/tools/icarus/ivtest/ivltests/clkgen_reg.v:13:4: disable isn't underneath a begin with name: 'checking'
regress-sv_pr3366114_iv,1,disable,%Error: sv-tests/third_party/tools/icarus/ivtest/ivltests/pr3366114.v:16:7: disable isn't underneath a begin with name: 'checking'
=== "fork disable (Support disabling fork by name #5432)"
regress-vlg_always319C_iv,1,disable,%Error: sv-tests/third_party/tools/icarus/ivtest/ivltests/always3.1.9C.v:43:11: disable isn't underneath a begin with name: 'foo'
regress-vlg_always319D_iv,1,disable,%Error: sv-tests/third_party/tools/icarus/ivtest/ivltests/always3.1.9D.v:45:11: disable isn't underneath a begin with name: 'block_id'
regress-vlg_disable36A_iv,1,disable,%Error: sv-tests/third_party/tools/icarus/ivtest/ivltests/disable3.6A.v:65:5: disable isn't underneath a begin with name: 'FF'
regress-vlg_disable36B_iv,1,disable,%Error: sv-tests/third_party/tools/icarus/ivtest/ivltests/disable3.6B.v:69:10: disable isn't underneath a begin with name: 'task_a'
regress-vlg_disable_cleanup_iv,1,disable,%Error: sv-tests/third_party/tools/icarus/ivtest/ivltests/disable_cleanup.v:22:3: disable isn't underneath a begin with name: 'counter'
regress-vlg_pr540b_iv,1,disable,%Error: sv-tests/third_party/tools/icarus/ivtest/ivltests/pr540b.v:163:4: disable isn't underneath a begin with name: 'gam'
regress-vlg_pr540c_iv,1,disable,%Error: sv-tests/third_party/tools/icarus/ivtest/ivltests/pr540c.v:32:2: disable isn't underneath a begin with name: 'command_block_reset'
regress-vlg_pr987_iv,1,disable,%Error: sv-tests/third_party/tools/icarus/ivtest/ivltests/pr987.v:17:11: disable isn't underneath a begin with name: 'restartable'
regress-vlg_sdw_dsbl_iv,1,disable,%Error: sv-tests/third_party/tools/icarus/ivtest/ivltests/sdw_dsbl.v:45:5: disable isn't underneath a begin with name: 'my_block'
=== "fork disable . (sv-test-suite)"
regress-sv_fork_join_dis_iv,1,,%Error-UNSUPPORTED: sv-tests/third_party/tools/icarus/ivtest/ivltests/fork_join_dis.v:36:17: Unsupported: disable with '.'
regress-vlg_pr540_iv,255,,sv-tests/third_party/tools/icarus/ivtest/ivltests/pr540.v Unsupported: disabling block that contains a fork
| if (!m_ftaskp->exists([targetp = nodep->targetp()](const AstNodeBlock* blockp) | ||
| -> bool { return blockp == targetp; })) { | ||
| // Disabling a fork, which is within the same task, is not a problem | ||
| nodep->v3warn(E_UNSUPPORTED, "Unsupported: disabling fork from task / function"); |
There was a problem hiding this comment.
| nodep->v3warn(E_UNSUPPORTED, "Unsupported: disabling fork from task / function"); | |
| nodep->v3warn(E_UNSUPPORTED, "Unsupported: disabling fork from different block"); |
Given how I read the code.
If the problem was really task/functions then we should check after inlining, as an inline of a task should make this ok. (Or maybe that does apply here, so likewise should move this check.)
There was a problem hiding this comment.
The problem is really task/functions. Disabling a fork from a different block is supported if disable is outside a task. Inlining should fix some cases, but not all tasks are inlined, as the methods from the test I added.
|
These tests are tests of |
It adds support for
disableused in task when it disables a fork in the same task. It also changes thet_disable_insidetest, because that test tested a case whendisablewas outside the fork.