Update to C++17 minimum requirement. #2190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
force-pushed
the
20221103-update-to-c++-17
branch
from
6aabf72 to
ece8d27
Compare
Contributor
|
This might help: #2203 |
hzeller
force-pushed
the
20221103-update-to-c++-17
branch
from
ece8d27 to
a2f26a4
Compare
Plus small changes to make compiler happy. Signed-off-by: Henner Zeller <hzeller@google.com>
hzeller
force-pushed
the
20221103-update-to-c++-17
branch
from
a2f26a4 to
c313635
Compare
Contributor
|
@hzeller Thanks for pioneering the effort.
Currently, it is running well. |
Contributor
|
@vaughnbetz CI is green for this PR. It look like we have no problem when leveling up the C++ standard requirement to C++17. Can we merge this PR? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.