[Spelling] Fixed Simple Spelling Mistakes in Pack and Power #3359
+86
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the simple spelling mistakes in most of VPR. The only VPR folder left is route which has quite a few since it is so documented. That needs to come in its own PR.
github-actions
bot
added
VPR
AmirhosseinPoolad
approved these changes
Nov 25, 2025
|
|
||
| //Change the target | ||
| lb_nets[ilb_net].terminals[iterm] = pin_index; | ||
| lb_nets[ilb_net].terminals[term_idx] = pin_index; |
Contributor
There was a problem hiding this comment.
This entire function is actually terrifying the way it uses and reuses term_idx. Can you please put a note somewhere to refactor it in a later PR?
Contributor
Author
There was a problem hiding this comment.
I actually already have this on my radar. This will be part of future packer cleanups.
This reuse of the variable is not too bad, I tried to resolve it but its a bit more involved for this PR. Its just searching for a terminal index which matches some attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the simple spelling mistakes in most of VPR. The only VPR folder left is route which has quite a few since it is so documented. That needs to come in its own PR.