Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong statement continue alignment. #1495

Open
veripoolbot opened this issue Sep 1, 2019 · 4 comments
Open

Wrong statement continue alignment. #1495

veripoolbot opened this issue Sep 1, 2019 · 4 comments
Labels

Comments

@veripoolbot
Copy link
Collaborator

@veripoolbot veripoolbot commented Sep 1, 2019


Author Name: Enze Chi
Original Redmine Issue: 1495 from https://www.veripool.org


With verilog-mode from master branch (be9b5af)

I have 3 expression as below, after press , I got wrong alignment for the example code as below:

     startc_c         <= (valid && (state == THE_START));
     end_c             <= (valid && (state == THE_END));
     valid_c           <= (valid &&
                 (state != IDLE) &&
                 (state != SKIP_DATA));


But the expected alignment should be:

     startc_c  <= (valid && (state == THE_START));
     end_c     <= (valid && (state == THE_END));
     valid_c   <= (valid &&
                          (state != IDLE) &&
                          (state != SKIP_DATA));

@veripoolbot
Copy link
Collaborator Author

@veripoolbot veripoolbot commented Sep 1, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-09-01T15:09:28Z


I get:

module x;
    initial begin
       startc_c         <= (valid && (state == THE_START));
       end_c            <= (valid && (state == THE_END));
       valid_c          <= (valid &&
                            (state != IDLE) &&
                            (state != SKIP_DATA));

which seems correct. Perhaps you have some variable settings that change behavior? Please send your verilog-submit-bug-report variable dump.

@veripoolbot
Copy link
Collaborator Author

@veripoolbot veripoolbot commented Sep 2, 2019


Original Redmine Comment
Author Name: Enze Chi
Original Date: 2019-09-02T12:08:47Z


Here's the variable dump

@veripoolbot
Copy link
Collaborator Author

@veripoolbot veripoolbot commented Sep 2, 2019


Original Redmine Comment
Author Name: Enze Chi
Original Date: 2019-09-02T12:16:02Z


I just realise that when I call "verilog-indent-buffer", the alignment is as expected. The problem happens when press "ENTER" at the end of last line in the example code. It will align the "<=" and "!=" which it should not.

@veripoolbot
Copy link
Collaborator Author

@veripoolbot veripoolbot commented Sep 15, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-09-15T15:40:36Z


Doesn't see a obvious fix; if someone would be willing to investigate further and provide a patch it would be appreciated.

@veripoolbot veripoolbot added the indents label Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.