Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concat parsing issue #1200

Closed
veripoolbot opened this issue Sep 6, 2017 · 4 comments
Closed

Concat parsing issue #1200

veripoolbot opened this issue Sep 6, 2017 · 4 comments

Comments

@veripoolbot
Copy link
Collaborator

@veripoolbot veripoolbot commented Sep 6, 2017


Author Name: Wilson Snyder (@wsnyder)
Original Redmine Issue: 1200 from https://www.veripool.org


From https://www.veripool.org/boards/28/topics/1626?r=2332#message-2332

aaaand we are back :P Apparently there is a bug, where not enough cleanup is done... following commit fixes this.
uastw-embsys/Verilog-Perl@0ef1bbb

Stefan, nit - please file issues so I don't miss patches. Anyhow when I patch and run 42_dumpcheck.t a bunch of times I sometimes get "Attempt to free unreferenced scalar: SV 0x23e4b30, Perl interpreter: .... during global destruction." so something is still unstable. Can you run it in a loop and take a look?

@veripoolbot

This comment has been minimized.

Copy link
Collaborator Author

@veripoolbot veripoolbot commented Sep 7, 2017


Original Redmine Comment
Author Name: Stefan Tauner (@stefanct)
Original Date: 2017-09-07T09:16:58Z


Wilson Snyder wrote:

From https://www.veripool.org/boards/28/topics/1626?r=2332#message-2332

aaaand we are back :P Apparently there is a bug, where not enough cleanup is done... following commit fixes this.
uastw-embsys/Verilog-Perl@0ef1bbb

Stefan, nit - please file issues so I don't miss patches.

NP, I pondered about it but thought keeping it all together in the thread is better...

Anyhow when I patch and run 42_dumpcheck.t a bunch of times I sometimes get "Attempt to free unreferenced scalar: SV 0x23e4b30, Perl interpreter: .... during global destruction." so something is still unstable. Can you run it in a loop and take a look?

I can reproduce what you see in about 5% of the runs. However, it is not this patch that is producing this problem. I have git bisected this and can conclude that it was introduced already in 3d2ecdb Support for buses and concats in Netlist, msg1626.
Will look into it further now-ish...

@veripoolbot

This comment has been minimized.

Copy link
Collaborator Author

@veripoolbot veripoolbot commented Sep 7, 2017


Original Redmine Comment
Author Name: Stefan Tauner (@stefanct)
Original Date: 2017-09-07T16:10:53Z


That one hurts a bit... one work day led to the attached (and also pushed) patch :'(
The other patch is nevertheless needed to fix the other problem. Sorry!

@veripoolbot

This comment has been minimized.

Copy link
Collaborator Author

@veripoolbot veripoolbot commented Sep 8, 2017


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2017-09-08T01:23:20Z


Excellent work, again.

Pushed both to git towards 3.441. I'll wait a day for this to settle then push out a release.

@veripoolbot

This comment has been minimized.

Copy link
Collaborator Author

@veripoolbot veripoolbot commented Sep 9, 2017


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2017-09-09T01:56:27Z


In 3.442.

@veripoolbot veripoolbot closed this Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.