Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 04critic written badly #164

Closed
veripoolbot opened this issue Sep 28, 2008 · 0 comments
Closed

Test 04critic written badly #164

veripoolbot opened this issue Sep 28, 2008 · 0 comments
Assignees

Comments

@veripoolbot
Copy link
Collaborator

@veripoolbot veripoolbot commented Sep 28, 2008


Author Name: Wilson Snyder (@wsnyder)
Original Redmine Issue: 164 from https://www.veripool.org
Original Date: 2008-09-28
Original Assignee: Wilson Snyder (@wsnyder)


This bug was cloned from Perl-RT, rt39654.

Email addresses have have been truncated.

Id: 	39654
Status: 	resolved
Left: 	0 min
Queue: 	Verilog-Perl
Owner: 	Nobody
Requestors: 	ANDK <ANDK@>

Severity: 	Normal
Broken in: 	3.042
Fixed in: 	3.043

Sun Sep 28 07:19:01 2008 ANDK - Ticket created

Subject: 	Test 04critic written badly

Your 04critic.t contains:

eval { use Test::Perl::Critic; };

This doesn't work as intended. Block eval compiles the contained code at
compile time, not runtime. So it failes right at the moment the script
is parsed and if Tast::Perl::Critic isn't installed, the use statement
fails immediately and the eval is never reached.

See the manpage for Test::Perl::Critic how this can be written safely.

Thanks,

Mon Sep 29 13:48:23 2008 WSNYDER - Fixed in 3.043 added

Mon Sep 29 13:48:24 2008 WSNYDER - Correspondence added

Fixed in 3.043, thanks for filing the bug.

Mon Sep 29 13:48:25 2008 RT_System - Status changed from 'new' to 'open'

Mon Sep 29 13:48:26 2008 WSNYDER - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.