Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessor doesn't handle one case of definition substitution properly #1659

Open
veripoolbot opened this issue Jan 10, 2020 · 2 comments
Open
Assignees

Comments

@veripoolbot
Copy link
Collaborator

@veripoolbot veripoolbot commented Jan 10, 2020


Author Name: Topa Tota
Original Redmine Issue: 1659 from https://www.veripool.org

Original Assignee: Wilson Snyder (@wsnyder)


If you run the preprocessor on this code

`define test(a1,a2) ((a1) + (a2))

`test val  
( 1,2)
</code>

Output will be




((val    1) + (2))
</code>

It should give an error since there is no opening parenthesis after the definition name "test". However, what happens is that everything between the definition name and opening parenthesis gets prepended into the first argument.

This issue can mess up the code without the user detecting any errors. For example, user forgets to pass arguments to the definition name and a few lines later has a function call with same number of arguments.

@veripoolbot

This comment has been minimized.

Copy link
Collaborator Author

@veripoolbot veripoolbot commented Jan 10, 2020


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2020-01-10T11:52:59Z


Will fix this after next Verilator release. (Verilator has same preprocessor.)

@veripoolbot

This comment has been minimized.

Copy link
Collaborator Author

@veripoolbot veripoolbot commented Jan 11, 2020


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2020-01-11T14:16:44Z


Fixed in git towards eventual 3.472 release.

Also added to Verilator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.