Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding feature for case modifiers in SV #33
A buddy here is trying to use the sigparser on some SV code that uses 'unique case' modifiers.
The patch is attached.
I really could not figure out how to test this change properly. I added 'unique'
I am not as familiar with the design of the software to know if I have broken any other part of the parser.
Original Redmine Comment
Love getting patches! You did all of the right things.
I just made a few trivial changes (the yNAME should match keyword NAME). Also looking at the spec there's a "unique if" construct so I threw that in too.
All checked into git, and will be in the next release.
As for the testing, I generally add it to verilog/parser_bugs.v. The tests will still fail, because there's different modules or filenames. So run the test that fails with "t/sigparser.t". A "diff test_dir/35.dmp t/35_sigparser.out" will show the differences (generally trivial). If they make sense then "cp test_dir/35.dmp t/35_sigparser.out" to make the tests now pass.