Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module port lists do not support interfaces with constant unpacked dimension #815

Closed
veripoolbot opened this issue Sep 4, 2014 · 3 comments
Closed
Assignees

Comments

@veripoolbot
Copy link
Collaborator

@veripoolbot veripoolbot commented Sep 4, 2014


Author Name: Glen Gibb
Original Redmine Issue: 815 from https://www.veripool.org
Original Date: 2014-09-04
Original Assignee: Wilson Snyder (@wsnyder)


A syntax error is produced when parsing a module port list that contains an interface with an unpacked dimension of the constant_expression type. (i.e., not constant range). For example:

module bad (
     my_iface    iface_inst[2]
);

Attached is a complete example that shows the erroneous behavior.

@veripoolbot

This comment has been minimized.

Copy link
Collaborator Author

@veripoolbot veripoolbot commented Sep 4, 2014


Original Redmine Comment
Author Name: Glen Gibb
Original Date: 2014-09-04T23:46:33Z


Doing a little bit of digging in VParseBison.y, I'm guessing that it's hitting a rule from portE that goes to rangeListE rather than one that goes to variable_dimensionListE. (rangeListE seems to require unpacked dimensions to be of the form [a:b] instead of the [a] form I used.)

@veripoolbot

This comment has been minimized.

Copy link
Collaborator Author

@veripoolbot veripoolbot commented Sep 10, 2014


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2014-09-10T19:36:59Z


You're exactly right about the problem.

Fixed in git towards 3.405.

@veripoolbot

This comment has been minimized.

Copy link
Collaborator Author

@veripoolbot veripoolbot commented Sep 21, 2014


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2014-09-21T13:02:51Z


In 3.406.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.