Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling chained define line +define+A+B #847

Closed
veripoolbot opened this issue Nov 13, 2014 · 3 comments
Closed

Handling chained define line +define+A+B #847

veripoolbot opened this issue Nov 13, 2014 · 3 comments
Assignees

Comments

@veripoolbot
Copy link
Collaborator

@veripoolbot veripoolbot commented Nov 13, 2014


Author Name: Adam Krolnik
Original Redmine Issue: 847 from https://www.veripool.org
Original Date: 2014-11-13
Original Assignee: Wilson Snyder (@wsnyder)


In a filelist, handling the line +define+A+B does not match NC or VCS.
Both NC and VCS expand this line to be equivalent to +define+A +define+B, while Verilog-Perl
inteprets it as +define+A=B

L% cat b.lst
+define+A+B
b.v

L% cat b.v
module b;
reg [63:0] B; initial B = "B";
reg [63:0] C; initial C = "C";
ifdef C initial $display("C is %s", C );
endif ifdef B
initial $display("B was correctly found defined.");
else initial $display("B was not defined from +define+A+B. A was defined as %0s.", A);
`endif
endmodule

Both NC and VCS report:
B was correctly found defined.

Running vppprec (-f b.lst) I get:
...
initial $display("B was not defined from +define+A+B. A was defined as %0s.", B);

One suggested change to Verilog/Getopt.pm, line 130 (I don't understand the vcs_style logic.)
< elsif (($param =~ /^+define+([^+=])+=$/ # This is not correct + != =
< || $param =~ /^+define+(.
?)()$/) && $self->{vcs_style}) {
< $self->define($1,$2,undef,1);
< }

NC/VCS also accept +define+A+B+C (equivalent to +define+A +define+B ...)

strings (A, A=B) can be combined with + to set multiple options. e.g. A+B=4+C+D=2

A

A=B

elsif ($param =~ /^+define+(.)$/) #Tokenize next
{
foreach my $tok (split("\+", $1))
{
my ($a, $b) = $tok =~ m/^([^=]
)=?(.*)$/;
$self->define($a,$b,undef,1);
}
}

@veripoolbot

This comment has been minimized.

Copy link
Collaborator Author

@veripoolbot veripoolbot commented Nov 13, 2014


Original Redmine Comment
Author Name: Adam Krolnik
Original Date: 2014-11-13T16:28:57Z


Sorry about the formating. The possible code is:

	elsif ($param =~ /^\+define\+(.*)$/)  #Tokenize next
           {
	  foreach my $tok (split("\\+", $1))
	    {
             my ($a, $b) = $tok =~ m/^([^=]*)=?(.*)$/;
	    $self->define($a,$b,undef,1);
	    }
	  }

@veripoolbot

This comment has been minimized.

Copy link
Collaborator Author

@veripoolbot veripoolbot commented Nov 14, 2014


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2014-11-14T00:06:44Z


Fixed in git towards 3.407.

@veripoolbot

This comment has been minimized.

Copy link
Collaborator Author

@veripoolbot veripoolbot commented Nov 15, 2014


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2014-11-15T13:37:27Z


In 4.308.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.