Search

[Malabarba]

Implements searching.
Accepts query, tags, and excluded tags.

Would be nice to have tag completion here, but obviously relies on #137.

[vermiculus]

I don't suppose there is any way we can test this… I honestly can't think of a way that is guaranteed not to break. We could take a bet on the search results of, say, grandma on TeX.SX and see if we get the appropriate question's ID.

[Malabarba]

That should be fine, I think. Search for grandma, check if any of the results is the one we expected.

There are two very basic sanity checks we can do:

• perform a simple search, just to make sure it doesn't error.
• do a search with excluded-tags, but without tags nor query, and make sure it does error.

Other reasonable tests:

• search for a popular tag on SO (like c++) and verify the length of the returned vector (which should be a full page).
• make an obviously crazy query, and make sure it's empty.
• search for the org tag on Emacs.SE, but exclude another tag like ox-html, and check that none of the results contain the excluded tag.

[vermiculus]

Shouldn't this be

(if current-prefix-arg
    (sx--interactive-site-prompt)
  (or sx-question-list--site
      (sx--interactive-site-prompt)))

Or something to this effect? (I feel like the logic above can be simplified, though.)

[Malabarba]

Using the question-list--site variable means that the user can switch site in the search-results buffer.
It's not an incredibly useful feature, but who knows... it could come in handy to repeat a search on a different site.

[vermiculus]

How does this look?

[Malabarba]

Great!

[Malabarba]

You had asked something about completing read. We should use it once we have the tag lists. Right now there's nothing to complete against.

[vermiculus]

Right now there's nothing to complete against.

Fair enough :) We should have tag lists pretty soon -- work on the bot can continue now that #187 is (hopefully) ready.

[vermiculus]

Also, sorry about any Branch: cruft -- it's something I need to do for work in my commits. It won't be the case with the new job 😄 (On the other hand, I'll be using svn... 😦)

[Malabarba]

How good is your svn knowledge?

[vermiculus]

Poor, but TortoiseSVN will likely be good enough for my purposes. Knowing how I act though in new environments, I'll likely just pick up bits and pieces over the next few months until I have a good knowledge of the internals.