New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor design changes to remove "JSQ" branding :) #1

Merged
merged 1 commit into from Apr 16, 2018

Conversation

Projects
None yet
2 participants
@jessesquires
Copy link
Contributor

jessesquires commented Apr 16, 2018

Hey @vermont42 ! 馃憢

Really happy to see that you were able to build your own site by forking mine. 馃槃

I wanted to send you this PR to remove some of my "branding" (colors, fonts, etc.). Everything that I removed now just falls back to Bootstrap defaults (which are great).

  • Remove custom UbuntuMono font
  • Remove custom link and button colors

I'm hoping you'll accept these changes!

Other notes:

  • I noticed you have _site/ checked in. Usually you want this to be ignored. Was that intentional?
@jessesquires

This comment has been minimized.

Copy link
Contributor Author

jessesquires commented Apr 16, 2018

A few screenshots of what this looks like now:

screen shot 2018-04-15 at 7 00 31 pm

screen shot 2018-04-15 at 7 13 10 pm

@@ -4,7 +4,7 @@
<subtitle>A Blog by Josh Adams</subtitle>
<link href="http://racecondition.software/feed.xml" rel="self" />
<link href="http://racecondition.software" />
<updated>2018-04-08T16:56:34-07:00</updated>
<updated>2018-04-15T19:03:07-07:00</updated>

This comment has been minimized.

@vermont42

vermont42 Apr 16, 2018

Owner

Why this change?

This comment has been minimized.

@jessesquires

jessesquires Apr 16, 2018

Author Contributor

Ah, this is because you check-in the _site/ directory. So this is an artifact of running jekyll build.

From the original PR description:

I noticed you have _site/ checked in. Usually you want this to be ignored. Was that intentional?

You probably want _site/ to be in your .gitignore. But, it might depend on your hosting setup.

This comment has been minimized.

@jessesquires

jessesquires Apr 16, 2018

Author Contributor

Oh, I just realized you don't have a .gitignore 馃槉

I'd recommend adding one. 馃槃

This comment has been minimized.

@vermont42

vermont42 Apr 16, 2018

Owner

I will do so.

@vermont42 vermont42 merged commit ef2daf1 into vermont42:master Apr 16, 2018

@jessesquires

This comment has been minimized.

Copy link
Contributor Author

jessesquires commented Apr 16, 2018

Thanks @vermont42 ! 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment