Skip to content
Permalink
Browse files

Don't validate configuration.password against SIP URI password BNF gr…

…ammar (fix #74).
  • Loading branch information
ibc committed Mar 18, 2013
1 parent 3f84b30 commit fea13267c496160a234d2dca27c58ad7bd661d25
Showing with 1 addition and 5 deletions.
  1. +1 −5 src/UA.js
@@ -1018,11 +1018,7 @@ UA.configuration_check = {
},

password: function(password) {
if(JsSIP.Grammar.parse(password, 'password') === -1) {
return;
} else {
return password;
}
return String(password);
},

register: function(register) {

2 comments on commit fea1326

@iwanbk

This comment has been minimized.

Copy link
Contributor

iwanbk replied Mar 19, 2013

@ibc
Hi, why not fixing it by modifying this line https://github.com/versatica/JsSIP/blob/master/src/Grammar/src/Grammar.pegjs#L134 ?
By add '@' on that line.

@ibc

This comment has been minimized.

Copy link
Member Author

ibc replied Mar 19, 2013

@iwanbk no because such a "password" field means "the password component of a URI user portion" (something 100% useless in SIP, maybe just useful in HTTP URIs tons of years ago) and has nothing to do with the password used for Digest authentication.

Please sign in to comment.
You can’t perform that action at this time.