New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S-67470 require data trackingid #14

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@andrew-codes
Copy link
Collaborator

andrew-codes commented Feb 11, 2019

No description provided.

@kmmarsh kmmarsh force-pushed the S-67470_require-data-trackingid branch from 137a220 to 6464ff3 Feb 11, 2019

@andrew-codes
Copy link
Collaborator Author

andrew-codes left a comment

For the items we make this a required prop: we should update the README docs files to include this to reflect that it is required?

@andrew-codes

This comment has been minimized.

Copy link
Collaborator Author

andrew-codes commented Feb 11, 2019

Also, List.Item's primary action is optional, so the trackingID should also be optional.

@walkerrandolphsmith walkerrandolphsmith deleted the S-67470_require-data-trackingid branch Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment