New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize branching and merging history #1043

Closed
borekb opened this Issue May 11, 2016 · 4 comments

Comments

Projects
3 participants
@borekb
Copy link
Member

borekb commented May 11, 2016

We could add a panel that would visualize the branching and merging history of the site, perhaps with the summary of commits that happened there (maybe optionally, to keep the UI simple). Something like this:

                          ^
             PRODUCTION   |    STAGING
                          |
                          +-------+
                          |       |
Added Production post *   |       |   * Added About Us page
    Edited option xyz *   |       |   * Customized theme
                          |       |   * Changed theme
                          |       |
                          +-------+
                          |
   Updated site title *   |
  Trashed Hello World *   |
         Installed VP *   |
                          +

In the future, we could also consider SourceTree-like visualization of commit graph right to the main table but maybe it would be just a clutter for common non-technical users

2016-05-11 15_40_41-clipboard

@borekb borekb added this to the 4.0 milestone May 11, 2016

@borekb borekb assigned Ishirak and unassigned vasek17 Aug 18, 2016

@Ishirak Ishirak added the in progress label Sep 19, 2016

@borekb

This comment has been minimized.

Copy link
Member Author

borekb commented Sep 19, 2016

We discussed some of the specifics today with @Ishirak, @JanVoracek and @octopuss. This feature could be quite big and unwieldy one day, however, let's start small and expand in the future.

Some of the core decisions:

  • We'll start with rendering the current page of commits only. For example, if I'm on page 1 our of 7, the graph will only visualize the page 1.
    • Technically, this means that the graph can easily be rendered client-side. If we were to render the full history, it would not be efficient to download hundreds of commits only to show a couple of branching and merging points.
  • There might be "load more" or "view the full history" switches later, however, that might require new server-side endpoints as per the previous bullet point.

Regarding the UI:

  • The core is to be able to draw the "rails". Whether we'll display commit details or not is secondary.
  • Let's develop the UI as a separate component / panel first, but we also discussed how the visualization could perhaps be a watermark under the main table, or something like that.

Ishirak added a commit that referenced this issue Oct 6, 2016

Ishirak added a commit that referenced this issue Oct 6, 2016

Ishirak added a commit that referenced this issue Oct 6, 2016

Ishirak added a commit that referenced this issue Oct 6, 2016

Ishirak added a commit that referenced this issue Oct 6, 2016

Ishirak added a commit that referenced this issue Oct 6, 2016

[#1043] Added another option to change visualisation's visibility and…
… fixed sometimes inaccurate rendering of the visualisation.

Ishirak added a commit that referenced this issue Oct 6, 2016

Ishirak added a commit that referenced this issue Oct 6, 2016

Ishirak added a commit that referenced this issue Oct 6, 2016

Ishirak added a commit that referenced this issue Oct 6, 2016

Ishirak added a commit that referenced this issue Oct 6, 2016

@Ishirak Ishirak referenced this issue Oct 6, 2016

Merged

Branch visualisation #1128

1 of 2 tasks complete

vasek17 added a commit that referenced this issue Oct 7, 2016

vasek17 added a commit that referenced this issue Oct 7, 2016

@vasek17 vasek17 closed this in #1128 Oct 7, 2016

@vasek17 vasek17 removed the in progress label Oct 7, 2016

@borekb

This comment has been minimized.

Copy link
Member Author

borekb commented Oct 7, 2016

🍀 Shipped in 4.0-alpha1 at this point. Keeping this issue open for future updates until 4.0 is final.

@borekb borekb reopened this Oct 7, 2016

@borekb

This comment has been minimized.

Copy link
Member Author

borekb commented Oct 7, 2016

Taking it back: let's do it as with #1036, i.e., close the original issue and create smaller issue for post-alpha improvements.

@borekb borekb closed this Oct 7, 2016

@borekb borekb removed in review labels Oct 10, 2016

@borekb

This comment has been minimized.

Copy link
Member Author

borekb commented Oct 11, 2016

🚢 Shipped in 4.0-alpha1.

Ishirak added a commit that referenced this issue Oct 13, 2016

vasek17 added a commit that referenced this issue Oct 18, 2016

@borekb borekb added this to Done in 4.0-alpha1 May 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment