New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'edit' -> 'update' action verb #1120

Closed
borekb opened this Issue Oct 3, 2016 · 3 comments

Comments

Projects
2 participants
@borekb
Copy link
Member

borekb commented Oct 3, 2016

All database scopes in actions.yml define at least the create, edit and delete actions. The edit verb was probably chosen because posts were the first scope we ever worked on, however, the update verb is better and we should switch to it before 4.0 is released and people start defining edit actions.

This will be a breaking change. Not a breaking change after all, see PR.


🏁 PR #1251

@borekb borekb added this to the 4.0 milestone Oct 3, 2016

@borekb borekb referenced this issue Oct 3, 2016

Merged

Plugin support #1075

@borekb

This comment has been minimized.

Copy link
Member Author

borekb commented Oct 4, 2016

BTW, WordPress uses the word "edit" to enter the post editor, or "quick edit" to enter the inline form. After the editing, in both cases, the button is labeled "Update".

image

image

@borekb

This comment has been minimized.

Copy link
Member Author

borekb commented Jun 7, 2017

Note to self: backwards compatibility (not breaking sites with commits from older VP versions) can be added by mapping edit to update in TrackedChangeInfo.

UPDATE 1: This will not be possible, see PR #1251 description.

UPDATE 2: It's possible in the end, see PR.

@borekb borekb moved this from New to In Progress in 4.0-beta Jun 29, 2017

@borekb

This comment has been minimized.

Copy link
Member Author

borekb commented Jun 29, 2017

I've started looking at this and this caught my attention, from actions.yml:

post:
  actions:
    edit:
      message: Edited %VP-Post-Format% '%VP-Post-Title%'
      priority: 12
    update: Updated %VP-Post-Format% '%VP-Post-Title%'

We have both the post/edit and post/update actions there, however, I don't see any tests for post/update and generally can't find any reference about it anywhere in the code. @JanVoracek can you remember why it's there or how it's utilized, if at all?

@borekb borekb closed this in #1251 Jul 4, 2017

@borekb borekb moved this from In Progress to Done in 4.0-beta Jul 4, 2017

@borekb borekb added the significant label Jul 4, 2017

pavelevap added a commit to pavelevap/versionpress-for-woocommerce that referenced this issue Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment