New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpconfig.neon -> wp-config.php #566

Closed
borekb opened this Issue Nov 24, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@borekb
Copy link
Member

borekb commented Nov 24, 2015

Since #303 we have an internal VersionPress configuration stored in vpconfig.neon in the plugin folder. This causes trouble e.g. during update where this file could be lost.

The suggestion is to move the configuration into the standard wp-config.php file which is already git-ignored, specific to some environment etc. so it's probably better to use it than to develop some other configuration mechanism (we considered moving vpconfig.neon one directory up, using options etc.).

@borekb borekb added this to the 3.0 milestone Nov 24, 2015

@JanVoracek

This comment has been minimized.

Copy link
Member

JanVoracek commented Nov 24, 2015

Also we need to find out what should wp vp config do without the vpconfig.neon (do we need it anymore?). Or how to switch to the old GUI without vpconfig.neon.

@JanVoracek JanVoracek self-assigned this Jan 8, 2016

@borekb borekb added in progress and removed in progress labels Jan 15, 2016

@borekb borekb added the size: s label Jan 26, 2016

@borekb

This comment has been minimized.

Copy link
Member

borekb commented Jan 26, 2016

Will need updating docs.

@JanVoracek JanVoracek assigned octopuss and unassigned JanVoracek Feb 22, 2016

@borekb

This comment has been minimized.

Copy link
Member

borekb commented Feb 22, 2016

Had a brief discussion with @JanVoracek about this today. A couple of points worth keeping:

  • My idea was just to change the implementation of the wp vp config command (#303) to manipulate wp-config.php instead of vpconfig.neon.
  • @JanVoracek pointed out that this manipulation can be tricky - the contents of wp-config.php can be arbitrary PHP so the command probably cannot be made 100% reliable.
  • Maybe the easiest thing to do is to make the vp config command internal and update the docs to let users know to manually update their wp-config.php file, similarly to what WP core does with constants like WP_DEBUG etc. After all, we just have a single "public" config option today (git-binary) and maybe it should be the responsibility of the WP-CLI project to provide command for updating config (I personally believe it would be useful even if it can cover "only" 90% of cases).
  • We would keep the current code to handle internal things like flipping the UI switch for testing. However, publicly, there would be no mentions of vpconfig.neon and the vp config command would not be public.
@JanVoracek

This comment has been minimized.

Copy link
Member

JanVoracek commented Mar 1, 2016

Our internal command for manipulation with wp-config.php is implemented as part of PR #756. Maybe we could use it (probably restricted to our constants only).

@JanVoracek JanVoracek assigned JanVoracek and unassigned octopuss Mar 1, 2016

JanVoracek added a commit that referenced this issue Mar 2, 2016

@JanVoracek JanVoracek referenced this issue Mar 4, 2016

Merged

vpconfig.neon -> wp-config.php #762

3 of 3 tasks complete

@JanVoracek JanVoracek added in review and removed in progress labels Mar 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment