Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Display environment in which a commit originated #609
We discussed a couple of UI options for this feature today:
@vasek17 please try a couple of options.
I've tried couple of variants and need your feedback:
1. New text column
3. Tag-like with colors
4. Colorful circles at the beginning of the row
5. Colorful circles in the second column
6. Colorful circles at the message column
7. Dynamic colorful circles
8. Dynamic line at the beginning of the row
This is an excellent job, @vasek17!
The last implementation (no. 8) probably looks the coolest but can be a bit tricky when it comes to details, for example:
The circles are probably best reserved for small avatars of users, like on GitHub or in overv.io.
If we wanted a not-so-cool but simple and straightforward solution, no. 3 would work quite well I think. It's the best from 1..3.
Overall, I'd go for 8 even if some aspects of it might be slightly problematic. It looks really nice!
A couple of technical comments when I look at it:
Definitely. I will try to tune it (also with checkboxes from #201) for the best experience.
In my opinion it should be only in the first row. We can display the environment in the overview under the change informations.
In my opinion it would be sufficient to display color lines with environment name in the overview (after expanding the line).
Actually, master has always the same (hardcoded) color, however I like @JanVoracek's idea to differentiate only commits from other environments.
I have a few colors (stolen from github