New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of NEON, replace with YAML #703

Closed
borekb opened this Issue Feb 8, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@borekb
Copy link
Member

borekb commented Feb 8, 2016

This is basically a reincarnation of #35 but this time for real :) We need to get rid of the NEON format because it's not familiar to most developers, even though it's a good format and arguably a bit nicer than YAML. But its value added is not large enough.

The closest replacement is YAML, we could also think about being a bit more radical and getting rid of the static format entirely and model the schema in some form of PHP code (hooks or something like that). But switching to YAML would be the simplest.

@borekb borekb added this to the 3.0 milestone Feb 8, 2016

@borekb

This comment has been minimized.

Copy link
Member

borekb commented Mar 1, 2016

For VP 3.0, we'll just switch to YAML without any bigger changes. The places that need to updated:

  • wordpress-schema.neon. The only two problematic syntax things are:
    1. The function reference needs to be quoted (wordpress-schema.neon#L21)
    2. The shut-up operator in mn-references (wordpress-schema.neon#L58) needs to replaced with something else. Proposed character is ~ (we tried a couple).
  • vpconfig.neon – we'll be getting rid of this file entirely (#566)
  • wordpress-shortcodes.neon - created recently as part of #654 (link to source), will not be a problem to convert to YAML.
  • test-config.neon - should be straightforward to convert to YAML, again.

@JanVoracek JanVoracek self-assigned this Mar 1, 2016

JanVoracek added a commit that referenced this issue Mar 4, 2016

@JanVoracek JanVoracek referenced this issue Mar 4, 2016

Merged

Replace NEON with YAML #765

2 of 2 tasks complete

@JanVoracek JanVoracek added in review and removed in progress labels Mar 4, 2016

@JanVoracek JanVoracek referenced this issue Mar 6, 2016

Merged

Check PHP extensions in RequirementsChecker #759

2 of 2 tasks complete

@borekb borekb added the significant label Mar 9, 2016

@borekb borekb changed the title Get rid of NEON, replace with another format Get rid of NEON, replace with YAML Mar 9, 2016

@JanVoracek JanVoracek removed the in review label Mar 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment