New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split *meta entities into separate files #883

Open
JanVoracek opened this Issue Apr 7, 2016 · 4 comments

Comments

@JanVoracek
Member

JanVoracek commented Apr 7, 2016

Now we save postmeta, usermeta, termmeta and commentmeta together with their "parent" entity. Maybe we should consider to save them individually. It will be better for merging, reverts, the code will be more simple and straightforward.

The only disadvantages are:

  • a lot of INI files
  • maybe a worse context in a full diff – the user will see only the postmeta, not the post itself (or maybe it will be an advantage, who knows)
@borekb

This comment has been minimized.

Member

borekb commented Apr 7, 2016

Technically, I think we should do this – it's kind of similar to the options split (#473). The diff could be improved on the UI level, no problem there.

Agree with the milestone – we should release this as part of 3.0.

@JanVoracek JanVoracek modified the milestones: 4.0, 3.0 Apr 11, 2016

@JanVoracek

This comment has been minimized.

Member

JanVoracek commented Apr 11, 2016

Moving this to 4.0. Bug #876 is caused by wrong detection of PHP binary – there's no merge conflict. However, it's maybe right thing to do. We will discuss it again in 4.0.

@borekb

This comment has been minimized.

Member

borekb commented Apr 11, 2016

Agree, it's not clear what the right approach is here. Let's watch the issue some more, if people report issues with the current storage format etc.

@borekb

This comment has been minimized.

Member

borekb commented May 7, 2017

As some of the issues linking here (#1147, #1148) show, this should be done. The best milestone for it is 4.0-beta, let's see if we can manage to squeeze it there.

@borekb borekb removed the discussion label May 7, 2017

@borekb borekb added this to New in 4.0-beta May 8, 2017

@JanVoracek JanVoracek removed this from New in 4.0-beta Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment