Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jCasbin authorization provider #215

Closed
wants to merge 1 commit into from
Closed

Conversation

@hsluoyz
Copy link

@hsluoyz hsluoyz commented May 17, 2018

No description provided.

@pmlopes
Copy link
Member

@pmlopes pmlopes commented Jun 6, 2018

@hsluoyz thank you for your pull request, I am reviewing it and it look good, however I'm afraid of merging it right now for a couple of reasons:

  1. Once it is merged then the code maintenance becomes our responsibility (and to be honest, we don't have experience on casbin in the team)
  2. This will require IP reviews since the module includes a non optional dependency

I was wondering why not add it to the (j)casbin organization where the knowledge lives, and instead:

Let me know what you think about it!

@hsluoyz
Copy link
Author

@hsluoyz hsluoyz commented Feb 12, 2021

Understood, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants