diff --git a/src/main/asciidoc/index.adoc b/src/main/asciidoc/index.adoc index a7808e2..d9cd06c 100644 --- a/src/main/asciidoc/index.adoc +++ b/src/main/asciidoc/index.adoc @@ -312,8 +312,6 @@ The following metrics are provided: * `vertx.worker-pool-size` - A <> of the number of threads in the worker pool * `vertx.cluster-host` - A <> of the cluster-host setting * `vertx.cluster-port` - A <> of the cluster-port setting -* `vertx.verticles` - A <> of the number of verticles currently deployed -* `vertx.verticles.` - A <> of the number of deployment of a particular verticle === Event bus metrics diff --git a/src/main/java/io/vertx/ext/dropwizard/impl/VertxMetricsImpl.java b/src/main/java/io/vertx/ext/dropwizard/impl/VertxMetricsImpl.java index 2fdd1fc..859a757 100644 --- a/src/main/java/io/vertx/ext/dropwizard/impl/VertxMetricsImpl.java +++ b/src/main/java/io/vertx/ext/dropwizard/impl/VertxMetricsImpl.java @@ -42,7 +42,6 @@ class VertxMetricsImpl extends AbstractMetrics implements VertxMetrics { private final DropwizardMetricsOptions options; - private final Counter verticles; private Handler doneHandler; private final boolean shutdown; private final Map clientReporters = new ConcurrentHashMap<>(); @@ -51,7 +50,6 @@ class VertxMetricsImpl extends AbstractMetrics implements VertxMetrics { super(registry, baseName); this.options = metricsOptions; - this.verticles = counter("verticles"); this.shutdown = shutdown; gauge(options::getEventLoopPoolSize, "event-loop-size"); @@ -68,18 +66,6 @@ String projectName(String name) { return name; } - @Override - public void verticleDeployed(Verticle verticle) { - verticles.inc(); - counter("verticles", verticleName(verticle)).inc(); - } - - @Override - public void verticleUndeployed(Verticle verticle) { - verticles.dec(); - counter("verticles", verticleName(verticle)).dec(); - } - @Override public EventBusMetrics createEventBusMetrics() { return new EventBusMetricsImpl(this, nameOf("eventbus"), options); diff --git a/src/test/java/io/vertx/ext/dropwizard/MetricsTest.java b/src/test/java/io/vertx/ext/dropwizard/MetricsTest.java index c9464e4..24ddbbb 100644 --- a/src/test/java/io/vertx/ext/dropwizard/MetricsTest.java +++ b/src/test/java/io/vertx/ext/dropwizard/MetricsTest.java @@ -1052,36 +1052,6 @@ public void testVertxMetrics() throws Exception { assertNull(metrics.getJsonObject("vertx.cluster-port")); } - @Test - public void testVerticleMetrics() throws Exception { - int verticles = 5; - CountDownLatch latch = new CountDownLatch(verticles); - AtomicReference ref = new AtomicReference<>(); - for (int i = 0; i < 5; i++) { - vertx.deployVerticle(new AbstractVerticle() {}, ar -> { - assertTrue(ar.succeeded()); - ref.set(ar.result()); // just use the last deployment id to test undeploy metrics below - latch.countDown(); - }); - } - - awaitLatch(latch); - - JsonObject metrics = metricsService.getMetricsSnapshot(vertx); - assertNotNull(metrics); - assertFalse(metrics.isEmpty()); - - assertCount(metrics.getJsonObject("vertx.verticles"), (long) verticles); - - vertx.undeploy(ref.get(), ar -> { - assertTrue(ar.succeeded()); - assertCount(metricsService.getMetricsSnapshot(vertx).getJsonObject("vertx.verticles"), (long) verticles - 1); - testComplete(); - }); - - await(); - } - @Test public void testScheduledMetricConsumer() { int messages = 18;