Move code to master branch #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… defaults easily Use our own jgroups file (based on default multicast+tcp) to get the lock and counter protocols added.
From time to time, 1 or 2 tests were failing (not always the same). But the symptoms were identical: each of the nodes created thought it was the leader. This may happen when nodes on the same machine start at the same time, and ping messages are lost in both ways.
No need to transfer data for a meaning less value
Since we now have near cache, the infinispan cache no longer needs to be replicated. My testing with the request/reply scenario show that CPU usage is similar to vertx-hazelcast after the change. Before, one my CPU was around 100% at 500msg/sec, because we had to iterate through the set of mappings.
- get latest fixes - reduce dependency size by 1M
We don't use cache loaders ... etc so we can use the minimal set of deps If a user wants this in his app, he will have to tune the stack
…tting system property
…roblem to the user (as all Vert.x modules do) Kept the JGroups redirection for testing (JBossLogging redirection is no longer needed since we don't depend on infinispan-embedded any more) Also, fixed the logback scope (wasn't set to test)
Workaround the null classloader issue with JBossMarshalling Prevent NPE because view listener could be started before the nodeListener is set Do not block cache update with listeners (sync=false) Clear nearch in async multimap in case two partitions get merged back into one (so we eventually get consistent subs data across nodes)
Fixes bug introduced by 7faa21c
- Favor availability over consistency - Eviction is disabled by default - Use replication mode for __vertx.haInfo Will avoid blocking/slow traversal at the expense of slower writes and memory penalty
This reverts commit f235543.
This reverts commit 2e835ac.
Tested and documenting the result here.
- Externalize deployment commands - Run all steps in script phase because a failure in after_success does not fail the build
This is because it's currently based on JGroups Locks while the expected semantic is a semaphore with a single permit
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vietj can you have a look? Thanks