New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype of Future assertions #53

Merged
merged 5 commits into from Oct 29, 2018

Conversation

2 participants
@slinkydeveloper
Copy link
Member

slinkydeveloper commented Oct 22, 2018

Base on #52 discussion

Signed-off-by: francesco francescoguard@gmail.com

Prototype of Future assertions
Signed-off-by: francesco <francescoguard@gmail.com>

@slinkydeveloper slinkydeveloper requested a review from jponge Oct 22, 2018

@slinkydeveloper slinkydeveloper added this to the 3.6.0 milestone Oct 22, 2018

jponge and others added some commits Oct 29, 2018

Update src/main/java/io/vertx/junit5/VertxTestContext.java
Co-Authored-By: slinkydeveloper <francescoguard@gmail.com>
Update src/main/java/io/vertx/junit5/VertxTestContext.java
Co-Authored-By: slinkydeveloper <francescoguard@gmail.com>
@jponge

This comment has been minimized.

Copy link
Member

jponge commented Oct 29, 2018

This looks good to me @slinkydeveloper ;-)

slinkydeveloper added some commits Oct 29, 2018

Fixed other typos
Signed-off-by: francesco <francescoguard@gmail.com>
Fixed typo in test
Signed-off-by: francesco <francescoguard@gmail.com>

@jponge jponge self-assigned this Oct 29, 2018

@jponge jponge added the enhancement label Oct 29, 2018

@jponge

This comment has been minimized.

Copy link
Member

jponge commented Oct 29, 2018

Thanks!

@jponge jponge merged commit 2a2043f into master Oct 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jponge jponge deleted the future_apis branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment