Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upPrototype of Future assertions #53
Conversation
slinkydeveloper
requested a review
from
jponge
Oct 22, 2018
slinkydeveloper
added this to the 3.6.0 milestone
Oct 22, 2018
jponge
reviewed
Oct 29, 2018
jponge
reviewed
Oct 29, 2018
jponge
and others
added some commits
Oct 29, 2018
This comment has been minimized.
This comment has been minimized.
|
This looks good to me @slinkydeveloper ;-) |
jponge
reviewed
Oct 29, 2018
slinkydeveloper
added some commits
Oct 29, 2018
jponge
self-assigned this
Oct 29, 2018
jponge
added
the
enhancement
label
Oct 29, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
jponge
merged commit 2a2043f
into
master
Oct 29, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
jponge
deleted the
future_apis
branch
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
slinkydeveloper commentedOct 22, 2018
Base on #52 discussion
Signed-off-by: francesco francescoguard@gmail.com