Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs editing #9

Merged
merged 16 commits into from Feb 14, 2017

Conversation

@vietj
Copy link
Contributor

commented Feb 13, 2017

@ppatierno here are the docs edits + enabling polyglot

@@ -43,27 +43,116 @@
* Example about Kafka consumer and producer creation
* @param vertx
*/
public void example1(Vertx vertx) {
public void createConsumerJava(Vertx vertx) {

This comment has been minimized.

Copy link
@ppatierno

ppatierno Feb 14, 2017

Member

For being polyglot we have the example which uses Map. Why in this example with Properties don't we use the enums instead of strings as keys in the properties bag ?

This comment has been minimized.

Copy link
@vietj

vietj Feb 14, 2017

Author Contributor

yes I will change it

This comment has been minimized.

Copy link
@ppatierno

ppatierno Feb 14, 2017

Member

Sorry ... other than keys even the values if possible (i.e. StringSerializer.class instead of the string)

* Example about Kafka consumer and producer creation
* @param vertx
*/
public void createProducerJava(Vertx vertx) {

This comment has been minimized.

Copy link
@ppatierno

ppatierno Feb 14, 2017

Member

The same as createConsumerJava ...

This comment has been minimized.

Copy link
@vietj

vietj Feb 14, 2017

Author Contributor

ok

@@ -73,9 +162,9 @@ public void example1(Vertx vertx) {
*/
public void example2(KafkaConsumer<String, String> consumer) {

This comment has been minimized.

Copy link
@ppatierno

ppatierno Feb 14, 2017

Member

Should we change the name of the method even because the other names are changed ? (not use exampleXXX pattern anymore).

This comment has been minimized.

Copy link
@vietj

vietj Feb 14, 2017

Author Contributor

I'll rename them, it's easier to add new methods in the middle

This comment has been minimized.

Copy link
@ppatierno

ppatierno Feb 14, 2017

Member

Yes I like it :-) A lot of times I needed to shift example index in order to add a new one in the middle. I'll do that even for the vertx mqtt server.

@@ -130,17 +227,18 @@ public void example3(KafkaConsumer<String, String> consumer) {
*/
public void example4(KafkaConsumer<String, String> consumer) {

This comment has been minimized.

Copy link
@ppatierno

ppatierno Feb 14, 2017

Member

Changing method name ? (as before)

@@ -256,10 +386,9 @@ public void example7(KafkaConsumer<String, String> consumer) {
*/
public void example8(Vertx vertx, KafkaConsumer<String, String> consumer) {

This comment has been minimized.

Copy link
@ppatierno

ppatierno Feb 14, 2017

Member

Changing method name ?

This comment has been minimized.

Copy link
@vietj

vietj Feb 14, 2017

Author Contributor

yeah...

@vietj vietj merged commit 92ea2c7 into initial-work Feb 14, 2017
@ppatierno ppatierno deleted the docs-editing branch Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.