Join GitHub today
Issue48 hostnamenotasync #50
… hostname is passed between the different classes and is cached in a field in MailClientImpl. This is still wip, I am not happy with the constructors passing hostname, there should be an easier way to this. This has currently no test, I have starting writing a test with EasyMock/PowerMock, but that is not working Signed-off-by: alexlehm <firstname.lastname@example.org>
(for now decided to go without a test, the powermock stuff is too complicated, otherwise it would be necessary to rewrite the static class to facilitate testing) Signed-off-by: alexlehm <email@example.com>
There is still an access to the
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.