Move blocking random UUID generation to executor thread to keep pipeline reactive#400
Closed
Arooba-git wants to merge 1 commit into
Closed
Move blocking random UUID generation to executor thread to keep pipeline reactive#400Arooba-git wants to merge 1 commit into
Arooba-git wants to merge 1 commit into
Conversation
Contributor
|
I think we already have soemthing similar for RNG generation in vertx-auth, perhaps we can reuse it ? cc @pmlopes |
Member
|
@vietj we have several places in the Vert.x stack where we generate UUIDs, I don't believe it is necessary to use @Arooba-git if you want to use blockhound, consider allowing some blocking calls |
Contributor
|
@tsegismont we can discuss that next friday maybe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! 👋
Apparently the PoolOptions class has a blocking operation in its constructor that blocks the vertx event loop (as detected by BlockHound):
This PR fixes the blocking code to ensure the event loop remains non-blocking.