Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertx service proxy exposed to eventbusbridge #23

Closed
kurt-o-sys opened this issue Aug 6, 2015 · 1 comment
Closed

vertx service proxy exposed to eventbusbridge #23

kurt-o-sys opened this issue Aug 6, 2015 · 1 comment

Comments

@kurt-o-sys
Copy link

As far as I understand, due to the 'header' and 'body' sent to proxies, the proxy addresses cannot be used to expose the services using an eventbusbridge. The reason being: there is no header sent.
It would be nice to have service proxies to be able to expose their address, so they can be accessed from 'outside' (using the eventbusbridge). This could probably be a switch on the Proxygen annotation
There may be different strategies to do this:

  1. check if there is a 'header'. If not, check if the json message (body) contains a 'header' and 'body' field. If there is a header, well, that's how it's now. If there isn't, but there is a 'header' and 'body' in the message itself, things are pretty easy to 'extract'.
  2. different addresses may be used for the 'exposed' and 'concealed' version - configurable in the Proxygen annotation again?
  3. ...?
@kurt-o-sys kurt-o-sys reopened this Aug 6, 2015
@pmlopes
Copy link
Member

pmlopes commented Oct 6, 2015

Pull request #26 and #27 addressed this issue, you can now expose vertx-services to the eventbus and have generated JS bindings you can use with your browser, nodejs or even nashorn JVM clients.

@pmlopes pmlopes closed this as completed Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants