Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BodyHandler: document setDeleteUploadedFilesOnEnd #2450

Closed
vietj opened this issue Jul 21, 2023 · 2 comments · Fixed by #2504
Closed

BodyHandler: document setDeleteUploadedFilesOnEnd #2450

vietj opened this issue Jul 21, 2023 · 2 comments · Fixed by #2504
Assignees
@tsegismont
Labels
documentation enhancement
Milestone
4.5.0

Comments

@vietj
Copy link
Contributor

vietj commented Jul 21, 2023

Web body handler does have important settings that are not present in the documentation, and we should have them in the documentation so users are fully aware of it.

  • body limit
  • delete file upload on ends
  • handle file uploads
@vietj vietj added this to the 4.4.5 milestone Jul 21, 2023
@vietj vietj modified the milestones: 4.4.5, 4.4.6 Aug 30, 2023
@vietj vietj modified the milestones: 4.4.6, 4.5.0 Sep 12, 2023
@tsegismont tsegismont self-assigned this Nov 6, 2023
@tsegismont tsegismont changed the title Improve BodyHandler documentation BodyHandler: document setDeleteUploadedFilesOnEnd Nov 6, 2023
@tsegismont
Copy link
Contributor

Body limit and file uploads are already documented

tsegismont added a commit to tsegismont/vertx-web that referenced this issue Nov 6, 2023
@tsegismont
BodyHandler: document setDeleteUploadedFilesOnEnd
af848d2 
See vert-x3#2450

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit to tsegismont/vertx-web that referenced this issue Nov 6, 2023
@tsegismont
BodyHandler: document setDeleteUploadedFilesOnEnd
790d7de 
Resolves vert-x3#2450

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont mentioned this issue Nov 6, 2023
Merged
@tsegismont tsegismont linked a pull request Nov 6, 2023 that will close this issue
BodyHandler: document setDeleteUploadedFilesOnEnd #2504
Merged
@tsegismont tsegismont mentioned this issue Nov 6, 2023
Merged
tsegismont added a commit that referenced this issue Nov 7, 2023
@tsegismont
BodyHandler: document setDeleteUploadedFilesOnEnd (#2504)
2e264ca 
Resolves #2450

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont
Copy link
Contributor

Fixed by #2504

tsegismont added a commit that referenced this issue Nov 7, 2023
@tsegismont
BodyHandler: document setDeleteUploadedFilesOnEnd (#2505)
1849502 
See #2450

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsegismont tsegismont

Labels
documentation enhancement
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

BodyHandler: document setDeleteUploadedFilesOnEnd tsegismont/vertx-web
2 participants
@vietj @tsegismont