Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Client: Query parameters missing for SSL requests #563

Closed
svenjacobs opened this issue Mar 21, 2017 · 3 comments
Closed

Web Client: Query parameters missing for SSL requests #563

svenjacobs opened this issue Mar 21, 2017 · 3 comments

Comments

@svenjacobs
Copy link
Contributor

@svenjacobs svenjacobs commented Mar 21, 2017

Version

  • vert.x core: 3.4.1
  • vert.x web: 3.4.1

Context

I noticed that query parameters are lost when the request is SSL encrypted. For instance this is a request which works:

webClient.get("example", "/test")
        .putHeader("Accept-Version", "v1")
        .putHeader("Authorization", authorization)
        .addQueryParam("page", page.toString())
        .addQueryParam("per_page", perPage.toString())
        .send(...)

I created a test endpoint at my backend and logged the query parameters so I can confirm that they are incoming. However once I switch to SSL I can see that the query parameters are missing:

webClient.get(443, "example", "/test")
        .ssl(true)
        .putHeader("Accept-Version", "v1")
        .putHeader("Authorization", authorization)
        .addQueryParam("page", page.toString())
        .addQueryParam("per_page", perPage.toString())
        .send(...)

I'm not sure what I'm doing wrong here...

@vietj
Copy link
Contributor

@vietj vietj commented Mar 21, 2017

would you mind to create a test case ? that would help to find the issue :-)

@svenjacobs
Copy link
Contributor Author

@svenjacobs svenjacobs commented Mar 22, 2017

I found the problematic line in HttpRequestImpl. I believe it should be .setUri(requestURI) at line 279. Luckily there's already the PR #562 open addressing this.

pmlopes added a commit that referenced this issue Apr 7, 2017
…arams

Fix losing query parameters for SSL requests (issue #563)
@svenjacobs
Copy link
Contributor Author

@svenjacobs svenjacobs commented Apr 13, 2017

Closing since PR has been merged

@svenjacobs svenjacobs closed this Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.