Skip to content

Move blocking error logging to executor thread#2457

Closed
Arooba-git wants to merge 1 commit into
vert-x3:masterfrom
Arooba-git:fix-blocking-call-in-routing-context-impl
Closed

Move blocking error logging to executor thread#2457
Arooba-git wants to merge 1 commit into
vert-x3:masterfrom
Arooba-git:fix-blocking-call-in-routing-context-impl

Conversation

@Arooba-git

Copy link
Copy Markdown

Hi! :)

Thank you for this project.

This PR fixes a blocking call that happens when logging error as detected by BlockHound:
Screen Shot 2023-07-27 at 7 43 38 AM

We re-ran the tests to ensure the fix is non-intrusive.

@vietj

vietj commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

if you have issue with logging, you should configure it to log differently, i.e with an asynchronous logger. pehraps also you should avoid using java logger, https://dzone.com/articles/asynchronous-logging-with-log4j-2

@vietj vietj closed this Jul 27, 2023
@vietj

vietj commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

also that is a blocking call, but it does not report whether this call actually blocks in practice.

I see you using BlockHound and reporting issue accross the codebase to use an executor (that is not closed in your PR) and I think you should before reporting a PR discuss each case separately, there might be case where it is appropriare and case where it is not depending on the context / situation. It is not possible to use a dedicated executor to solve the situation everytime you see BlockFound reporting something.

Vert.x has a mechanism to detect blocking, and it detect blocking when it actually is a problem and not when it can potentially block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants